59a98843f7
Reuse a single long-poll HTTP client instead of creating one per Events() call (~every 30s). Make TLS skip-verify configurable via syncthing_insecure_tls. Log previously swallowed config errors. Add unit tests for all monitor trackers, config, and state logic. Add CI workflow (vet, golangci-lint, govulncheck, go test -race). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
91 lines
2.1 KiB
Go
91 lines
2.1 KiB
Go
package config
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
)
|
|
|
|
func withTempDir(t *testing.T) {
|
|
t.Helper()
|
|
dir := t.TempDir()
|
|
configDirOverride = dir
|
|
t.Cleanup(func() { configDirOverride = "" })
|
|
}
|
|
|
|
func TestLoad_Defaults(t *testing.T) {
|
|
withTempDir(t)
|
|
|
|
cfg := Load()
|
|
if cfg.SyncthingAddress != "localhost:8384" {
|
|
t.Errorf("expected default address, got %q", cfg.SyncthingAddress)
|
|
}
|
|
if !cfg.SyncthingInsecureTLS {
|
|
t.Error("SyncthingInsecureTLS should default to true")
|
|
}
|
|
if !cfg.EnableNotifications {
|
|
t.Error("EnableNotifications should default to true")
|
|
}
|
|
}
|
|
|
|
func TestSaveLoadRoundTrip(t *testing.T) {
|
|
withTempDir(t)
|
|
|
|
cfg := Load()
|
|
cfg.SyncthingAPIKey = "test-key-12345"
|
|
cfg.SyncthingAddress = "192.168.1.100:8384"
|
|
cfg.EnableRecentFiles = false
|
|
|
|
if err := Save(cfg); err != nil {
|
|
t.Fatalf("Save failed: %v", err)
|
|
}
|
|
|
|
// Clear cache so Load reads from disk
|
|
mu.Lock()
|
|
cached = nil
|
|
mu.Unlock()
|
|
|
|
loaded := Load()
|
|
if loaded.SyncthingAPIKey != "test-key-12345" {
|
|
t.Errorf("API key not round-tripped: got %q", loaded.SyncthingAPIKey)
|
|
}
|
|
if loaded.SyncthingAddress != "192.168.1.100:8384" {
|
|
t.Errorf("address not round-tripped: got %q", loaded.SyncthingAddress)
|
|
}
|
|
if loaded.EnableRecentFiles {
|
|
t.Error("EnableRecentFiles should be false after round-trip")
|
|
}
|
|
}
|
|
|
|
func TestBaseURL_TLSToggle(t *testing.T) {
|
|
cfg := Config{
|
|
SyncthingAddress: "localhost:8384",
|
|
SyncthingUseTLS: false,
|
|
}
|
|
if cfg.BaseURL() != "http://localhost:8384" {
|
|
t.Errorf("expected http URL, got %q", cfg.BaseURL())
|
|
}
|
|
|
|
cfg.SyncthingUseTLS = true
|
|
if cfg.BaseURL() != "https://localhost:8384" {
|
|
t.Errorf("expected https URL, got %q", cfg.BaseURL())
|
|
}
|
|
}
|
|
|
|
func TestLoad_InvalidJSON(t *testing.T) {
|
|
withTempDir(t)
|
|
|
|
// Write invalid JSON to the config path
|
|
if err := os.MkdirAll(configDir(), 0o755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := os.WriteFile(ConfigPath(), []byte("{invalid"), 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Should return defaults without panicking
|
|
cfg := Load()
|
|
if cfg.SyncthingAddress != "localhost:8384" {
|
|
t.Errorf("expected defaults on invalid JSON, got %q", cfg.SyncthingAddress)
|
|
}
|
|
}
|