calic/syncwarden
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Remove unused cached var in config package
Some checks failed
CI / lint (push) Failing after 43s
Details
CI / test (push) Successful in 37s
Details

Browse Source 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Axel Meyer
2026-03-04 01:15:24 +01:00
parent c967727ff8
commit 795e1348b8
2 changed files with 3 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
internal/config/config.go
View File

@@ -53,10 +53,7 @@ var defaults = Config{
LastEventID: 0, LastEventID: 0,
} }
var ( var mu sync.Mutex
mu sync.Mutex
cached *Config
)
// Load reads config from disk, merging with defaults. // Load reads config from disk, merging with defaults.
func Load() Config { func Load() Config {
@@ -71,7 +68,7 @@ func Load() Config {
if err := json.Unmarshal(data, &cfg); err != nil { if err := json.Unmarshal(data, &cfg); err != nil {
log.Printf("config: parse error: %v", err) log.Printf("config: parse error: %v", err)
} }
cached = &cfg
return cfg return cfg
} }
@@ -88,7 +85,7 @@ func Save(cfg Config) error {
if err != nil { if err != nil {
return err return err
} }
cached = &cfg
return os.WriteFile(ConfigPath(), data, 0o644) return os.WriteFile(ConfigPath(), data, 0o644)
} }

5
internal/config/config_test.go
View File

@@ -39,11 +39,6 @@ func TestSaveLoadRoundTrip(t *testing.T) {
t.Fatalf("Save failed: %v", err) t.Fatalf("Save failed: %v", err)
} }
// Clear cache so Load reads from disk
mu.Lock()
cached = nil
mu.Unlock()
loaded := Load() loaded := Load()
if loaded.SyncthingAPIKey != "test-key-12345" { if loaded.SyncthingAPIKey != "test-key-12345" {
t.Errorf("API key not round-tripped: got %q", loaded.SyncthingAPIKey) t.Errorf("API key not round-tripped: got %q", loaded.SyncthingAPIKey)